[PATCH] Enhancements for the DynTypedNode

Manuel Klimek klimek at google.com
Tue May 21 02:54:29 PDT 2013


  +doug

  Ok, after reading through the change for which it is needed (getting polymorphic dynamic matchers checkable at runtime), I think this looks fine, but I want Doug to take a look for the high level design here.


================
Comment at: include/clang/AST/ASTTypeTraits.h:40
@@ +39,3 @@
+
+  /// \brief Some shortcuts for base types.
+  static DynNodeType decl() { return DynNodeType(NTI_Decl); }
----------------
I'd get rid of the shortcut functions - I don't think they buy much, but make the code inconsistent.

================
Comment at: include/clang/AST/ASTFwd.h:14
@@ +13,3 @@
+//===-------------------------------------------------------------===//
+
+
----------------
Nit: I'd remove the extra newline for symmetry :)


http://llvm-reviews.chandlerc.com/D829



More information about the cfe-commits mailing list