[PATCH] [ms-cxxabi] Move CodeGenVTables::needsVTTParameter to ItaniumCXXABI.
Timur Iskhodzhanov
timurrrr at google.com
Mon May 20 06:19:30 PDT 2013
LGTM
================
Comment at: lib/CodeGen/CGCXXABI.h:326
@@ +325,3 @@
+ /// Return whether the given global decl needs a VTT parameter.
+ virtual bool NeedsVTTParameter(GlobalDecl GD);
+
----------------
I think we should eventually move this method completely into ItaniumCXXABI (as it doesn't make sense for some other ABIs) but I agree doing this right now would require too much of a code change.
Feel free to add a FIXME for that in the comment above.
http://llvm-reviews.chandlerc.com/D821
More information about the cfe-commits
mailing list