[PATCH] Implement string literal breaking on unbreakable token sequences.
Alexander Kornienko
alexfh at google.com
Mon May 13 17:39:13 PDT 2013
Reading the patch outside an editor revealed that "1111111111" and "aaaaaaaaaa" in tests are very inconvenient for counting columns ;) Could you change those to "12345678901234" or "abcdefghijk"?
Everything else looks good.
================
Comment at: lib/Format/Format.cpp:788
@@ +787,3 @@
+ // If a token that we cannot breaks protrudes, it means we were unable to
+ // break a sequence of tokens due to illegal breaks between the tokens.
+ // Thus, we recursively search backwards to try to find a breakable token.
----------------
illegal -> disallowed?
http://llvm-reviews.chandlerc.com/D789
BRANCH
break-strings-off-by-one
ARCANIST PROJECT
clang
More information about the cfe-commits
mailing list