[PATCH] Get rid of VTableContext::ComputeMethodVTableIndices() and VTableContext::getNumVirtualFunctionPointers()

[Reid Kleckner]

================
Comment at: lib/AST/VTableBuilder.cpp:2221
@@ -2220,3 @@
-  
-  // Itanium C++ ABI 2.5.2:
-  //   The order of the virtual function pointers in a virtual table is the 
----------------
We're losing some of these spec references.  It looks like this one should live in AddMethods().

================
Comment at: lib/AST/VTableBuilder.cpp:2319
@@ -2318,3 @@
-    //   If a class has an implicitly-defined virtual destructor, 
-    //   its entries come after the declared virtual function pointers.
-
----------------
I don't think Test16::D triggers this case because ~D is overriding ~C, so it goes into the vtable first.

When can you have an implicitly defined virtual dtor without overriding the method of a base class?  Is that possible? Good question for Richard or John.


http://llvm-reviews.chandlerc.com/D785