r181644 - Debug Info: Silently accept template argument packs

David Blaikie dblaikie at gmail.com
Fri May 10 16:36:39 PDT 2013


On Fri, May 10, 2013 at 3:56 PM, Eric Christopher <echristo at gmail.com> wrote:
> On Fri, May 10, 2013 at 3:53 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> Author: dblaikie
>> Date: Fri May 10 17:53:25 2013
>> New Revision: 181644
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=181644&view=rev
>> Log:
>> Debug Info: Silently accept template argument packs
>>
>> We could support the GCC extension DW_TAG_GNU_template_parameter_pack if
>> we're feeling adventurous, at some point - but I don't think GDB's doing
>> anything useful with it yet anyway.
>>
>> Modified:
>>     cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
>>     cfe/trunk/test/CodeGenCXX/debug-info-template.cpp
>>
>> Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=181644&r1=181643&r2=181644&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Fri May 10 17:53:25 2013
>> @@ -1264,10 +1264,12 @@ CollectTemplateParams(const TemplatePara
>>        // We could support this with the GCC extension
>>        // DW_TAG_GNU_template_template_param
>>        break;
>> +    case TemplateArgument::Pack:
>> +      // And this with DW_TAG_GNU_template_parameter_pack
>> +      break;
>>      // these next 4 should never occur
>>
>
> <Monty Python> 3 sir </Monty Python>

Well played. *tips hat*

r181650



More information about the cfe-commits mailing list