[PATCH] Use 'auto const&' for iterators whose deref operator returns a const var

Ariel Bernal ariel.j.bernal at intel.com
Thu May 9 10:24:41 PDT 2013


  Yes you are right the same_type() tests are redundant. The same functionality is being tested whenever the variable and initializer have the same unqualified type. So I removed them.
  I also added those comments you suggested.

Hi revane,

http://llvm-reviews.chandlerc.com/D759

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D759?vs=1902&id=1906#toc

Files:
  cpp11-migrate/LoopConvert/LoopActions.cpp
  cpp11-migrate/LoopConvert/LoopActions.h
  cpp11-migrate/LoopConvert/LoopMatchers.cpp
  cpp11-migrate/LoopConvert/LoopMatchers.h
  test/cpp11-migrate/LoopConvert/Inputs/structures.h
  test/cpp11-migrate/LoopConvert/iterator.cpp
  test/cpp11-migrate/LoopConvert/naming-conflict.cpp
  test/cpp11-migrate/LoopConvert/nesting.cpp
  test/cpp11-migrate/LoopConvert/single-iterator.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D759.6.patch
Type: text/x-patch
Size: 19808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130509/09e15d8b/attachment.bin>


More information about the cfe-commits mailing list