r181487 - put noisy "unknown command tag name" warning

[Douglas Gregor]

On May 9, 2013, at 8:53 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Thu, May 9, 2013 at 2:38 AM, Fariborz Jahanian <fjahanian at apple.com> wrote:
>> Author: fjahanian
>> Date: Wed May  8 18:38:56 2013
>> New Revision: 181487
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=181487&view=rev
>> Log:
>> put noisy "unknown command tag name"  warning
>> under -Wdocumentation-unknown-command and off by default.
>> patch by Dmitri Gribenko.
> 
> Hi Fariborz, Doug,
> 
> This turned out to be not good enough:
> 
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/2358/steps/build/logs/warnings%20%283808%29
> 
> We could fix all the warnings (doable, there are just a few headers
> that are included all over the place), but writing '\n' in a comment
> is not too uncommon, IMHO.  So I think we should not warn about
> unknown single-character commands (or at least in cases where it is a
> known escape sequence).
> 
> What do you think about this?

This seems like a reasonable heuristic.

> (My personal opinion is that selecting \ or @ for a command marker in
> Doxygen was a bad choice, but that ship has sailed long ago...)

We don't get to fix that now :(

	- Doug
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130509/3f939d7f/attachment.html>