[PATCH] Fix block comment parser

Rui Ueyama ruiu at google.com
Wed May 8 21:40:22 PDT 2013


Ping?


On Tue, Apr 16, 2013 at 5:35 AM, Chandler Carruth <chandlerc at google.com>wrote:

> There are lots of other folks who can take a look, including Richard,
> Doug, Argiris, etc... Unfortunately some of us are tied up in C++ standard
> committee meetings, but there should be replies before too long...
>
>
> On Tue, Apr 16, 2013 at 5:28 AM, Rafael EspĂ­ndola <
> rafael.espindola at gmail.com> wrote:
>
>> On 16 April 2013 04:00, Rui Ueyama <ruiu at google.com> wrote:
>> > Yes, I think the new while-loop is not in a very hot path, as it is
>> executed
>> > only when there's a '/' at the very beginning of a line in a block
>> comment.
>> > And it loops only when previous lines are continuation lines. That
>> should be
>> > pretty unusual. I think that's why this minor bug was not found until
>> now :)
>> >
>> > Can anyone else take a look?
>>
>> Chris I guess. He is not on code owners for it must I think most of
>> the lexer is still his.
>>
>> Cheers,
>> Rafael
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130508/51b14620/attachment.html>


More information about the cfe-commits mailing list