r181081 - [doc parsing]: Make warning about unknown command

[Douglas Gregor]

On May 8, 2013, at 4:00 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Thu, May 9, 2013 at 1:54 AM, jahanian <fjahanian at apple.com> wrote:
>> 
>> On May 8, 2013, at 3:52 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> 
>> On Sat, May 4, 2013 at 3:47 AM, Fariborz Jahanian <fjahanian at apple.com>
>> wrote:
>> 
>> Author: fjahanian
>> Date: Fri May  3 19:47:28 2013
>> New Revision: 181081
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=181081&view=rev
>> Log:
>> [doc parsing]: Make warning about unknown command
>> tags off by default for now. Move diagnostic code
>> to DiagnosticCommentKinds.td. // rdar://12381408
>> 
>> 
>> I think this should be moved a separate group (for example, a separate
>> flag under DocumentationPedantic group).  It causes way too much noise
>> even for LLVM and Clang.
>> 
>> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/2344/steps/build/logs/stdio
>> 
>> 
>> I agree. I was just looking at the log.
> 
> What do you think about -Wdocumentation-unknown-command flag name?  I
> can not think of anything shorter...

Fine by me.

>> (There's also a crash somewhere in diagnostic printing, BTW…)
>> 
>> 
>> I just fixed the crash
> 
> r181479?  Erm, sort of.  The root cause of the crash is still there.


Well, we need the set to include the flag you mention about. Fariborz, once you've done the above, please gather the set of commits (which should be very, very small!) needed to make this warning non-default on the 3.3 branch. We don't want to pull typo correction into 3.3 to do it, though.

	- Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130508/1c972f4e/attachment.html>