r180982 - Attempt to un-break the gdb buildbot.
Adrian Prantl
aprantl at apple.com
Tue May 7 15:24:35 PDT 2013
I agree about the commented out code, but what’s the story about the side effects? -- isEvaluatable is const, right?
On May 7, 2013, at 3:19 PM, Eric Christopher <echristo at gmail.com> wrote:
>> - if (++NumStopPoints == 1)
>> - FirstStopPoint = Loc;
>> + //if (++NumStopPoints == 1)
>> + LastStopPoint = Loc;
>>
>
> Eh? Commented out code? Also, side effects in an if conditional? Ew.
>
>> + NumReturnExprs += 1;
>> if (RV == 0 || RV->isEvaluatable(getContext()))
>> - ++NumSimpleReturnExprs;
>> + NumSimpleReturnExprs += 1;
>>
>
> Eh?
>
> -eric
More information about the cfe-commits
mailing list