r181071 - [Doc parsing] Provide diagnostics for unknown documentation

jahanian fjahanian at apple.com
Fri May 3 17:07:19 PDT 2013


On May 3, 2013, at 5:01 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Sat, May 4, 2013 at 2:15 AM, Fariborz Jahanian <fjahanian at apple.com> wrote:
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td?rev=181071&r1=181070&r2=181071&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td Fri May  3 18:15:20 2013
>> @@ -27,6 +27,10 @@ def backslash_newline_space : Warning<
>>   "backslash and newline separated by space">,
>>   InGroup<DiagGroup<"backslash-newline-escape">>;
>> 
>> +// comment parsing
>> +def warn_unknown_comment_command_name : Warning<
>> +  "unknown command tag name">, InGroup<DiagGroup<"comment-command-tag">>;
>> +
> 
> This does not belong to the Lex diagnostics.  It should go into
> DiagnosticCommentKinds.td.

But it is a lex kind of diagnostics. But…., I will move it.
- f

> 
>> --- cfe/trunk/lib/AST/CommentLexer.cpp (original)
>> +++ cfe/trunk/lib/AST/CommentLexer.cpp Fri May  3 18:15:20 2013
>> @@ -1,4 +1,5 @@
>> #include "clang/AST/CommentLexer.h"
>> +#include "clang/Lex/LexDiagnostic.h"
> 
> Please remove this include as per above.
> 
> Dmitri
> 
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/





More information about the cfe-commits mailing list