[PATCH] First revision of the dynamic ASTMatcher library

[Dmitri Gribenko]

  Just a few nitpicks.  LGTM.


================
Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:252-255
@@ +251,6 @@
+
+/// \brief Parse a token.
+///
+/// It will determine the type of the token and redirect to the appropriate
+/// parse function.
+bool Parser::parseExpressionImpl(VariantValue *Value) {
----------------
This comment is stale...

================
Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:56
@@ +55,3 @@
+  /// specific matcher nodes for more efficient lookup.
+  class TokenProcessor {
+  public:
----------------
This is the 'semantic analysis' (Sema) class, if we stick to Clang's terms.  Then the function inside it should be called like 'actOnMatcherExpression()'

================
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:11-13
@@ +10,5 @@
+/// \file
+/// \brief Template functions and classes to wrap matcher construct functions.
+///
+/// A collection of template function and classes that provide a generic
+/// marshalling layer on top of matcher construct functions.
----------------
s/Template functions/Function templates/


http://llvm-reviews.chandlerc.com/D714

BRANCH
  svn

ARCANIST PROJECT
  clang