[PATCH][Review request][analyzer] scan-build for windows

[Jordan Rose]

On May 1, 2013, at 19:00 , Anton Yartsev <anton.yartsev at gmail.com> wrote:

> On 02.05.2013 5:50, Jordan Rose wrote:
>> 
>> On May 1, 2013, at 18:43 , Anton Yartsev <anton.yartsev at gmail.com> wrote:
>> 
>>> On 02.05.2013 5:27, Jordan Rose wrote:
>>>> 
>>>> On May 1, 2013, at 18:24 , Anton Yartsev <anton.yartsev at gmail.com> wrote:
>>>> 
>>>>> On 02.05.2013 5:10, Jordan Rose wrote:
>>>>>> 
>>>>>> On May 1, 2013, at 18:08 , Anton Yartsev <anton.yartsev at gmail.com> wrote:
>>>>>> 
>>>>>>> On 01.05.2013 21:10, Jordan Rose wrote:
>>>>>>>> 
>>>>>>>> On May 1, 2013, at 6:38 , Anton Yartsev <anton.yartsev at gmail.com> wrote:
>>>>>>>> 
>>>>>>>>> On 01.05.2013 6:29, Jordan Rose wrote:
>>>>>>>>>> Comments:
>>>>>>>>>> 
>>>>>>>>>>> +use English;
>>>>>>>>>> 
>>>>>>>>>> According to http://perldoc.perl.org/English.html, it's probably better to use 
>>>>>>>>>> 
>>>>>>>>>> use English qw( -no_match_vars ) ;
>>>>>>>>>> 
>>>>>>>>>> ...not that scan-build's startup time matters that much.
>>>>>>>>> Currently this is used only for $OSNAME while short names are used for all other special perl variables.
>>>>>>>>> Considering that using English affects performance, what about rolling back to $^O and adding explanatory comment instead?
>>>>>>>> 
>>>>>>>> Ah, right, fair enough.
>>>>>>>> 
>>>>>>>> This looks good. Please go ahead and commit, but make sure that c++-analyzer is marked as executable for Unix-y systems.
>>>>>>> Committed at r180900. Attributes of c++-analyzer are: -rwxr-xr-x
>>>>>> 
>>>>>> Um, doesn't seem to be working for me. You may have to manually set svn:executable.
>>>>> Updated at r180901. Did this helped?
>>>> 
>>>> Hm, no, it did not. For some reason it still thinks it's a symlink on my system:
>>>> 
>>>> lrwxr-xr-x  1 jrose  staff   203B May  1 18:25 c++-analyzer@ -> #!/usr/bin/env perl??use Cwd qw/ abs_path /;?use File::Basename qw/ dirname /;?# Add scan-build dir to the list of places where perl looks for modules.?use lib dirname(abs_path($0));??do 'ccc-analyzer';?
>>>> 
>>>> Admittedly this is passing through git-svn, but maybe it's best to just remove the file entirely and then add it back?
>>>> 
>>>> Jordan
>>> Created a new plain file, copied the c++analyzer contents, removed c++analyzer from repository and added the new one.
>> 
>> Missing the svn:executable. ;-) But it is showing up as a plain file now for me, so that should do it.
> Done! At r180905. Is it now ok?

Yes, working perfectly now. Sorry for the runaround!

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130502/db47fec2/attachment.html>