[PATCH] First revision of the dynamic ASTMatcher library
Manuel Klimek
klimek at google.com
Thu May 2 01:18:56 PDT 2013
LGTM! thanks! Do you have commit rights?
================
Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:88
@@ +87,3 @@
+ /// \c parseMatcher function is a better approach to get a matcher object.
+ static bool parseValue(llvm::StringRef Code, TokenProcessor *Processor,
+ VariantValue *Value, Diagnostics *Error);
----------------
Nit: since this is not the preferred interface, I would put it below parseMatcher.
================
Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:102
@@ +101,3 @@
+ static DynTypedMatcher *parseMatcher(llvm::StringRef MatcherCode,
+ TokenProcessor *Processor,
+ Diagnostics *Error);
----------------
For the future: I'd like an overload that doesn't need the TokenProcessor :)
http://llvm-reviews.chandlerc.com/D714
BRANCH
svn
ARCANIST PROJECT
clang
More information about the cfe-commits
mailing list