[PATCH][Review request][analyzer] scan-build for windows

Jordan Rose jordan_rose at apple.com
Wed May 1 10:10:33 PDT 2013


On May 1, 2013, at 6:38 , Anton Yartsev <anton.yartsev at gmail.com> wrote:

> On 01.05.2013 6:29, Jordan Rose wrote:
>> Comments:
>> 
>>> +use English;
>> 
>> According to http://perldoc.perl.org/English.html, it's probably better to use 
>> 
>> use English qw( -no_match_vars ) ;
>> 
>> ...not that scan-build's startup time matters that much.
> Currently this is used only for $OSNAME while short names are used for all other special perl variables.
> Considering that using English affects performance, what about rolling back to $^O and adding explanatory comment instead?

Ah, right, fair enough.

This looks good. Please go ahead and commit, but make sure that c++-analyzer is marked as executable for Unix-y systems.

Thank you!
Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130501/2e7f82d0/attachment.html>


More information about the cfe-commits mailing list