[PATCH][Review request] AtomicExpr printed with extra comma

[Richard Smith]

Hi!


On Wed, May 1, 2013 at 9:29 AM, Joe Sprowes <sprowes at silkan.com> wrote:

> Hi,
>
> I am new to clang and want to get involved. Hopefully, someone will walk
> me through the process.
>
> I found that atomic expressions were printed with an extra comma following
> the argument list:
>
> For example:
>
> __c11_atomic_init(&i, 0);
>
> is printed as:
>
> __c11_atomic_init(&i, 0, );
>
> Attached is a patch to fix this.  I attached a test.
>

Patch and test both look good. We try to minimize the number of distinct
test files (this makes a difference to the efficiency of running the tests
in some contexts) so please merge this into an appropriate existing test
for -ast-print ("grep -r ast-print test/" to find them).

Also, as a procedural issue, please provide a single patch covering both
code changes and test changes. We prefer patches which can be applied with
patch -p0 (svn diff will create such patches by default, git diff needs a
little configuring).

Once that's done, send the patch and I'll commit it for you.

Thank you!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130501/f0b58a58/attachment.html>