[PATCH] [ms-cxxabi] Fix a number of bugs in the mangler.

Peter Collingbourne peter at pcc.me.uk
Wed Apr 24 20:48:54 PDT 2013



================
Comment at: lib/AST/MicrosoftMangle.cpp:1015
@@ -1002,5 +1014,3 @@
 
-  // If we're mangling a qualified array type, push the qualifiers to
-  // the element type.
-  if (split.Quals && isa<ArrayType>(T)) {
-    ty = Context.getASTContext().getAsArrayType(T);
+  switch (QMM) {
+  case QMM_Drop:
----------------
Timur Iskhodzhanov wrote:
> please add
> 
>   default:
>     llvm_unreachable("Unknown QMM type");
> 
> or something like that.
http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations


http://llvm-reviews.chandlerc.com/D709

BRANCH
  ms-mangler-bugs

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list