PR15802 Windows paths with trailing backslashes

Serge Pavlov sepavloff at gmail.com
Mon Apr 22 20:12:04 PDT 2013


What about converting all backslashes into '/' ? Driver already uses
it in many cases on Windows, a forward slash cannot be used in Windows
path, and it doesn't require escaping. Looks like a solution?

2013/4/23 Nikola Smiljanic <popizdeh at gmail.com>:
> Here's a patch that tries to solve
> http://llvm.org/bugs/show_bug.cgi?id=15802 The bug report contains a patch
> that doesn't conform to coding standards and doesn't solve the general
> issue. Basically backslashes must be escaped if they are followed by a
> double quote, or in our case if they appear at the end of the argument
> because clang puts quotes around every argument containing a backslash which
> creates the backslashes followed by a double quote situation. The solution
> is quadratic in nature but I don't think this makes a difference as such
> input isn't something we should be seeing. I tried to solve this with as
> little modifications to the existing code as possible.
>
> More info on the crazy rules here
> http://msdn.microsoft.com/en-us/library/bb776391%28v=vs.85%29.aspx
> http://msdn.microsoft.com/en-us/library/17w5ykft%28v=vs.85%29.aspx
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
Thanks,
--Serge



More information about the cfe-commits mailing list