r178360 - Improvement on r177086.

Adrian Prantl aprantl at apple.com
Tue Apr 16 17:55:18 PDT 2013


On Apr 15, 2013, at 7:56 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Fri, Mar 29, 2013 at 12:20 PM, Adrian Prantl <aprantl at apple.com> wrote:
>> Author: adrian
>> Date: Fri Mar 29 14:20:29 2013
>> New Revision: 178360
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=178360&view=rev
>> Log:
>> Improvement on r177086.
>> * Let DIType for block-captured self to point to the completed cached
>>  interface type.
>> rdar://problem/12767564
>> 
>> Modified:
>>    cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
>>    cfe/trunk/lib/CodeGen/CGDebugInfo.h
> 
> Test case?

That change is actually a sub-goal of r178361 (the next commit) and is covered by the metadata 
checks introduced in r178361. I guess I was too lazy to update the tests twice in a row back then.
(cf. http://llvm.org/viewvc/llvm-project?view=revision&revision=178361)
I agree that this is totally non-obvious, though. I’ll try not to do that in the future.

-- adrian



More information about the cfe-commits mailing list