r179236 - add mips target requirement to testcase

Adrian Prantl aprantl at apple.com
Wed Apr 10 17:07:05 PDT 2013

On Apr 10, 2013, at 4:58 PM, Jack Carter <Jack.Carter at imgtec.com> wrote:

> Why is the target requirement needed? There are other Mips specific tests in this test directory without it?

Not all buildbots build all targets.
That said, I don’t think that this was the problem here.
The error was the #include <stdio.h>. On a machine with no MIPS cross-develoment environment installed compiling the system headers with a nonexisting architecture defined would fail.

> Do I need to retrofit them?

If you are only emitting llvm code the target requirement is superficial and it might be safe to remove it again, since the test will be executed by more buildbots. But I didn’t realize this until now :-)

-- adrian

More information about the cfe-commits mailing list