[PATCH] Implement handling of include/exclude options for cpp11-migrate

Edwin Vane edwin.vane at intel.com
Wed Apr 10 07:48:48 PDT 2013



================
Comment at: cpp11-migrate/Core/IncludeExcludeInfo.h:26
@@ +25,3 @@
+  IncludeExcludeInfo();
+  IncludeExcludeInfo(llvm::StringRef Include, llvm::StringRef Exclude);
+
----------------
Better document this now to indicate what format the Include and Exclude data should be in (i.e. comma-separated lists of paths)

================
Comment at: cpp11-migrate/Core/IncludeExcludeInfo.h:28
@@ +27,3 @@
+
+  /// \brief Determine if the given file is safe to transform.
+  bool safeToTransform(llvm::StringRef FilePath);
----------------
"Safe to Transform" is not a concept for this class really. Maybe call it "isFileIncluded()".


http://llvm-reviews.chandlerc.com/D648



More information about the cfe-commits mailing list