[PATCH] Implement handling of include/exclude options for cpp11-migrate

Edwin Vane edwin.vane at intel.com
Wed Apr 10 07:23:00 PDT 2013

Comment at: cpp11-migrate/Core/IncludeExcludeInfo.cpp:23
@@ +22,3 @@
+static cl::opt<std::string> CLIncludePaths(
+    "include", cl::desc("Comma seperated list of filepaths to consider to be "
Manuel Klimek wrote:
> Just FYI: I personally have a strong dislike of putting command line arguments into library files - it means that every binary that happens to link in this file transitively will see this argument, which might not be a problem now, but in my experience it always leads to headaches down the road.
> What I'd do instead is: put the command line args into the main file, and have a constructor for IncludeExcludeInfo that takes the lists as arguments.
Maybe mark the command-line args hidden too for now since the information they provide is not actually used for anything yet in cpp11-migrate.


More information about the cfe-commits mailing list