[PATCH] Simplify the PNaCl/le32 ABI to ignore regparm

Derek Schuff dschuff at google.com
Mon Apr 8 13:03:53 PDT 2013

I think it might be better to just throw an error on regparm
attributes (i.e. by setting regParmMax=0 in PNaClTargetInfo) rather
than ignoring them. That way if someone tries to build against glibc
headers (the reason for this code's existence in the first place), it
will fail loudly rather than just silently generating incompatible

On Mon, Apr 8, 2013 at 11:22 AM, Eli Bendersky <eliben at google.com> wrote:
> Hello,
> This patch simplifies the PNaCl/le32 target ABI in the custom lowering code
> in lib/CodeGen/TargetInfo.cpp to ignore the regparm attribute and always
> pass integers without inreg. Tests and comments updated accordingly.
> Eli

More information about the cfe-commits mailing list