[PATCH] Adds the add-override transform to the cpp11-migrate tool.

Edwin Vane edwin.vane at intel.com
Fri Apr 5 07:50:26 PDT 2013


  Could you do a search for lines >80 columns? Some of the file headers look to have comments whose lines are too long.

  LG after fixing long lines and the one naming nit.


================
Comment at: tools/extra/cpp11-migrate/AddOverride/AddOverrideMatchers.h:21
@@ +20,3 @@
+/// Name to bind with matched expressions.
+extern const char *MethodId;
+
----------------
My bad, I know I suggested `MethodId` but for LLVM style it should be `methodId`.


http://llvm-reviews.chandlerc.com/D630



More information about the cfe-commits mailing list