[PATCH] Unit test support for Clang extra tools

Edwin Vane edwin.vane at intel.com
Wed Apr 3 08:13:31 PDT 2013


  Committed as r178661.


================
Comment at: test/Unit/lit.cfg:27
@@ +26,3 @@
+      lit.load_config(config, site_cfg)
+      raise SystemExit
+
----------------
Edwin Vane wrote:
> Tareq A. Siraj wrote:
> > Shouldn't  this be inside an else block?
> I'm not entirely sure. I just copied this functionality out of clang/test/Unit/CMakeLists.txt.
Just tested this out and it works as expected.

================
Comment at: unittests/cpp11-migrate/Makefile:14
@@ +13,3 @@
+TESTNAME = Cpp11MigrateTests
+LINK_COMPONENTS := asmparser bitreader support mc
+USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a clangDriver.a \
----------------
Edwin Vane wrote:
> Tareq A. Siraj wrote:
> > Why are the LINK_COMPONENTS and USEDLIBS different between CMake and autoconf?
> Because they're already different between extra/cpp11-migrate/CMakeLists.txt and extra/cpp11-migrate/Makefile. Everything seems to work fine in both builds the way it is so I just maintained the list.
Turns out the list of libraries linked in by autoconf and cmake are identical. It looks to boil down to CMake's superior dependency calculation logic.


http://llvm-reviews.chandlerc.com/D605



More information about the cfe-commits mailing list