[PATCH] Even better way to handle comments adjacent to preprocessor directives.

Manuel Klimek klimek at google.com
Wed Apr 3 05:37:40 PDT 2013


  lg, with minor comment nit


================
Comment at: lib/Format/UnwrappedLineParser.cpp:832
@@ +831,3 @@
+      // start parsing the directive so that they are not treated as a part of
+      // it.
+      flushComments(FormatTok.NewlinesBefore > 0);
----------------
I'd rephrase:
Comments stored before the preprocessor directive need to be output before the preprocessor directive, at the same level as the preprocessor directive, as we consider them to apply to the directive.


http://llvm-reviews.chandlerc.com/D617

BRANCH
  svn

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list