r178548 - [ms-cxxabi] Move MS inheritance model calculation into MemberPointerType

[Reid Kleckner]

On Tue, Apr 2, 2013 at 12:28 PM, Jordan Rose <jordan_rose at apple.com> wrote:

>
> On Apr 2, 2013, at 9:23 , Reid Kleckner <reid at kleckner.net> wrote:
>
> +enum MSInheritanceModel {
> +  IHM_Single,
> +  IHM_Multiple,
> +  IHM_Virtual,
> +  IHM_Unspecified
> +};
>
>
> This is /really/ bikeshedding, but what is "IHM"? "InHeritance Model"? I
> would have expected "MSIM" as the prefix here.
>

Yes.  :)  MSIM works for me too.  Three characters seemed to be the norm,
so I tried to fit that.

>     default: llvm_unreachable("unknown inheritance model");
> +    case IHM_Unspecified: ++Ints;  // VBTableOffset
> +    case IHM_Virtual:     ++Ints;  // VirtualBaseAdjustmentOffset
> +    case IHM_Multiple:    ++Ints;  // NonVirtualBaseAdjustment
> +    case IHM_Single:      break;   // Nothing
>
>
> Now that the switch statement covers all the enum cases (because the enum
> changed), you should remove the "default" case; otherwise this will
> complain on some builders.
>

Good to know.


> Sorry I didn't look at these in pre-commit.
> Jordan
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130402/d047d613/attachment.html>