[libcxx][PATCH] Fix for CMakelists.txt

Michael Spencer bigcheesegs at gmail.com
Mon Apr 1 12:44:26 PDT 2013


On Sun, Mar 31, 2013 at 8:29 AM, Howard Hinnant <hhinnant at apple.com> wrote:

> I know nothing about the CMake build system.  Please review:
>
> Thanks,
> Howard
>
> -----------
> The problem is the cmake script for libcxx is broken. I've attached what I
> think is the right fix for it. It was failing to copy cxxabi.h to the right
> place because it was generating to destination path like so
> /include/${dstdir}/ and dstdir can legally be blank from my interpretation
> of the script, and this would then generate a path like libcxx/include//
> which is illegal.
>

LGTM. Although I wonder why it worked for me.

- Michael Spencer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130401/6e2899cc/attachment.html>


More information about the cfe-commits mailing list