r178471 - Modifed debug-info-byval.cpp test to grep for .string or .asciz.

Jyotsna Verma jverma at codeaurora.org
Mon Apr 1 10:04:25 PDT 2013


Hi Eric,

Thanks for suggestion. I will fix the test case.

-Jyotsna

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


>-----Original Message-----
>From: Eric Christopher [mailto:echristo at gmail.com]
>Sent: Monday, April 01, 2013 11:06 AM
>To: Jyotsna Verma
>Cc: cfe-commits at cs.uiuc.edu
>Subject: Re: r178471 - Modifed debug-info-byval.cpp test to grep for
.string or
>.asciz.
>
>A better solution here would be to rewrite the test to check the IR output
>rather than the .s file output.
>
>Thanks.
>
>-eric
>
>On Mon, Apr 1, 2013 at 8:59 AM, Jyotsna Verma <jverma at codeaurora.org>
>wrote:
>> Author: jverma
>> Date: Mon Apr  1 10:59:25 2013
>> New Revision: 178471
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=178471&view=rev
>> Log:
>> Modifed debug-info-byval.cpp test to grep for .string or .asciz.
>> The assembly output for Hexagon contains ".string missing_arg".
>>
>>
>>
>> Modified:
>>     cfe/trunk/test/CodeGenCXX/debug-info-byval.cpp
>>
>> Modified: cfe/trunk/test/CodeGenCXX/debug-info-byval.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/debug-in
>> fo-byval.cpp?rev=178471&r1=178470&r2=178471&view=diff
>>
>===========================================================
>===========
>> ========
>> --- cfe/trunk/test/CodeGenCXX/debug-info-byval.cpp (original)
>> +++ cfe/trunk/test/CodeGenCXX/debug-info-byval.cpp Mon Apr  1 10:59:25
>> +++ 2013
>> @@ -23,7 +23,7 @@ void foo(EVT e);
>>  EVT bar();
>>
>>  void get(int *i, unsigned dl, VAL v, VAL *p, unsigned n, EVT
>> missing_arg) {
>> -//CHECK: .asciz "missing_arg"
>> +//CHECK: .{{asciz|string}} "missing_arg"
>>    EVT e = bar();
>>    if (dl == n)
>>      foo(missing_arg);
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list