[PATCH] Fixit for -Wreinterpret-case-class

Alexander Zinenko ftynse at gmail.com
Thu Mar 28 11:31:58 PDT 2013


I don't have commit access yet. Would you mind committing it for me?


On 28 March 2013 20:20, Jordan Rose <jordan_rose at apple.com> wrote:

> LGTM, go ahead and commit!
> Jordan
>
> On Mar 28, 2013, at 11:13 , Alexander Zinenko <ftynse at gmail.com> wrote:
>
> Indeed, thanks!
> Sorry that such a simple patch takes so much time.
> Here is the updated one.
>
> On 28 March 2013 19:53, Jordan Rose <jordan_rose at apple.com> wrote:
>
>> Actually, I just realized that the SourceRange here is a token range,
>> so CreateReplacement will do the right thing even if you just pass a single
>> location. (I realized this because you shouldn't have to do the -1 offset;
>> CharSourceRange is a half-open range like other C++ ranges.)
>>
>> Jordan
>>
>>
>> <13824fixit.patch>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130328/43952cda/attachment.html>


More information about the cfe-commits mailing list