[PATCH] [ms-cxxabi] Correctly compute the size of member pointers

[John McCall]

On Mar 28, 2013, at 9:27 AM, Reid Kleckner <rnk at google.com> wrote:
> This patch looks pretty close to done to me.  I started doing more codegen for these, and I'd like some way to share the code between lib/AST/MicrosoftCXXABI.cpp and lib/CodeGen/MicrosoftCXXABI.cpp.  In particular, I want to share the inheritance model computation stuff.  Any ideas on the best way to do that?
> 
> I could add CXXRecordDecl/MemberPointerType::getMSInheritanceModel(), if that's an OK place to put it.

Putting it on CXXRecordDecl makes sense.  You should make it return a proper enum, though, not an attribute kind.

John.