[clang-tools-extra] r178207 - modularize - revised to group duplicate symbols together in the error output.

[Chandler Carruth]

On Wed, Mar 27, 2013 at 6:34 PM, Chandler Carruth <chandlerc at google.com>wrote:

>
> On Wed, Mar 27, 2013 at 6:20 PM, John Thompson <
> John.Thompson.JTSoftware at gmail.com> wrote:
>
>>  struct Entry {
>> -  enum Kind {
>> +  enum KindType {
>>      Tag,
>>      Value,
>>      Macro
>>    } Kind;
>> +  static const int NumberOfKinds = 3;
>>
>
> Err...
>
> Check out the coding standards for thinks like "kind" enums. I think there
> is a much better pattern to follow here:
>
> struct Entry {
>   enum EnttryKind {
>     EK_Tag,
>     EK_Value,
>     EK_Macro,
>

Arrg. rouge mis-click... Finishing this:

struct Entry {
  enum EntryKind {
    EK_Tag,
    EK_Value,
    EK_Macro,

    EK_NumKinds
  } Kind;

  ...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130327/b77b57ee/attachment.html>