r178015 - Fix uninitialized read of CalleeWithThisReturn.
Evgeniy Stepanov
eugeni.stepanov at gmail.com
Wed Mar 27 00:03:46 PDT 2013
Someone already took care of this...
On Wed, Mar 27, 2013 at 10:49 AM, Evgeniy Stepanov
<eugeni.stepanov at gmail.com> wrote:
> Yes, initializing CalleeWithThisReturn in the constructor will fix
> both bugs and should be faster. I'll make the change in a moment.
>
> On Wed, Mar 27, 2013 at 10:38 AM, Alexey Samsonov <samsonov at google.com> wrote:
>>
>> On Tue, Mar 26, 2013 at 9:29 PM, John McCall <rjmccall at apple.com> wrote:
>>>
>>> On Mar 26, 2013, at 6:44 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com>
>>> wrote:
>>> > Author: eugenis
>>> > Date: Tue Mar 26 08:44:29 2013
>>> > New Revision: 178015
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=178015&view=rev
>>> > Log:
>>> > Fix uninitialized read of CalleeWithThisReturn.
>>> >
>>> > CalleeWithThisReturn can be left initialized if HasThisReturn() is
>>> > false.
>>> > This change reverses the order of checks in EmitFunctionEpilog such that
>>> > CalleeWithThisReturn is only examined when it has a meaningful value.
>>>
>>> Checking CalleeWithThisReturn is much faster than making that call. We
>>> should just initialize CalleeWithThisReturn properly in the constructor.
>>
>>
>> See also http://llvm.org/bugs/show_bug.cgi?id=15598
>>
>>>
>>>
>>> John.
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>>
>>
>> --
>> Alexey Samsonov, MSK
More information about the cfe-commits
mailing list