r177368 - Finish refactoring the tool selection logic.

Benyei, Guy guy.benyei at intel.com
Sun Mar 24 03:02:56 PDT 2013


Hi Rafael,
The patch works fine on my Windows machine - please commit it.

Thanks
   Guy

-----Original Message-----
From: Rafael EspĂ­ndola [mailto:rafael.espindola at gmail.com] 
Sent: Thursday, March 21, 2013 19:38
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu; Michael Spencer
Subject: Re: r177368 - Finish refactoring the tool selection logic.

On 19 March 2013 14:12, Benyei, Guy <guy.benyei at intel.com> wrote:
> Hi,
> I'm not really an expert of this issue, but it sounds right to fail with an error message, and then gracefully exit. The test could be XFAIL in windows.

OK. The attached patch produces a proper error if one tries to use -no-integrated-as on windows. I don't have a windows machine right now, would you mind testing it?

> Thanks
>     Guy

Thanks,
Rafael
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.




More information about the cfe-commits mailing list