modularize tests - please review

[Vane, Edwin]

Sorry it took me so long to get to this review. I agree with Sean regarding how the headers should be located relative to the header-list file. Using clang::HeaderSearch is probably overkill.

From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Sean Silva
Sent: Thursday, March 21, 2013 6:30 PM
To: Thompson, John
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: modularize tests - please review



On Wed, Mar 20, 2013 at 9:26 PM, Thompson, John <John_Thompson at playstation.sony.com<mailto:John_Thompson at playstation.sony.com>> wrote:
Sean,

I tried using -I to fix the path problem, but modularize doesn't use the include path when trying to read the files from the source input list.  That could be changed, but it's probably better to let it remain explicit where the sources come from.  Perhaps I could change modularize to look for the files relative to the list file, or add a separate option for specifying the directory to use for a reference, or perhaps both.


I think it makes sense to look for the files relative to the list file, with a commandline option to override that behavior.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130322/a232c712/attachment.html>