modularize tests - please review

[Thompson, John]

Sean,

I tried using -I to fix the path problem, but modularize doesn't use the include path when trying to read the files from the source input list.  That could be changed, but it's probably better to let it remain explicit where the sources come from.  Perhaps I could change modularize to look for the files relative to the list file, or add a separate option for specifying the directory to use for a reference, or perhaps both.

Thanks.

-John

From: Sean Silva [mailto:silvas at purdue.edu]
Sent: Tuesday, March 19, 2013 7:52 PM
To: Thompson, John
Cc: cfe-commits at cs.uiuc.edu; Vane, Edwin
Subject: Re: modularize tests - please review


On Tue, Mar 19, 2013 at 12:28 PM, Vane, Edwin <edwin.vane at intel.com<mailto:edwin.vane at intel.com>> wrote:
I tried running these tests on linux and they all fail when using a build directory separate from source directory. It looks like modularize is looking in the build directory for the headers listed in the input file. My guess modularize is using the current working directory to locate headers?  I suggest perhaps using a -I on the command line to modularize so you can specify the right directory in the source tree.


John, you may want to take a look at e.g. clang/test/CodeGenCXX/rtti-visibility.cpp for an example of using the `%S` lit variable to add the test's directory as an include path.

-- Sean Silva.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130321/84892f4d/attachment.html>