r177549 - Objective-C [qoi] more gracefull recovery when

[Fariborz Jahanian]

Author: fjahanian
Date: Wed Mar 20 13:09:33 2013
New Revision: 177549

URL: http://llvm.org/viewvc/llvm-project?rev=177549&view=rev
Log:
Objective-C [qoi] more gracefull recovery when 
'}' is missing for the ivar declarations.
// rdar://6854840

Modified:
    cfe/trunk/include/clang/Parse/Parser.h
    cfe/trunk/lib/Parse/ParseObjc.cpp
    cfe/trunk/test/Parser/missing-closing-rbrace.m

Modified: cfe/trunk/include/clang/Parse/Parser.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Parse/Parser.h?rev=177549&r1=177548&r2=177549&view=diff
==============================================================================
--- cfe/trunk/include/clang/Parse/Parser.h (original)
+++ cfe/trunk/include/clang/Parse/Parser.h Wed Mar 20 13:09:33 2013
@@ -1115,6 +1115,10 @@ private:
   DeclGroupPtrTy ParseObjCAtClassDeclaration(SourceLocation atLoc);
   Decl *ParseObjCAtInterfaceDeclaration(SourceLocation AtLoc,
                                         ParsedAttributes &prefixAttrs);
+  void HelperActionsForIvarDeclarations(Decl *interfaceDecl, SourceLocation atLoc,
+                                        BalancedDelimiterTracker &T,
+                                        SmallVectorImpl<Decl *> &AllIvarDecls,
+                                        bool RBraceMissing);
   void ParseObjCClassInstanceVariables(Decl *interfaceDecl,
                                        tok::ObjCKeywordKind visibility,
                                        SourceLocation atLoc);

Modified: cfe/trunk/lib/Parse/ParseObjc.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseObjc.cpp?rev=177549&r1=177548&r2=177549&view=diff
==============================================================================
--- cfe/trunk/lib/Parse/ParseObjc.cpp (original)
+++ cfe/trunk/lib/Parse/ParseObjc.cpp Wed Mar 20 13:09:33 2013
@@ -1228,6 +1228,22 @@ bool Parser::ParseObjCProtocolQualifiers
   return Result;
 }
 
+void Parser::HelperActionsForIvarDeclarations(Decl *interfaceDecl, SourceLocation atLoc,
+                                 BalancedDelimiterTracker &T,
+                                 SmallVectorImpl<Decl *> &AllIvarDecls,
+                                 bool RBraceMissing) {
+  if (!RBraceMissing)
+    T.consumeClose();
+  
+  Actions.ActOnObjCContainerStartDefinition(interfaceDecl);
+  Actions.ActOnLastBitfield(T.getCloseLocation(), AllIvarDecls);
+  Actions.ActOnObjCContainerFinishDefinition();
+  // Call ActOnFields() even if we don't have any decls. This is useful
+  // for code rewriting tools that need to be aware of the empty list.
+  Actions.ActOnFields(getCurScope(), atLoc, interfaceDecl,
+                      AllIvarDecls,
+                      T.getOpenLocation(), T.getCloseLocation(), 0);
+}
 
 ///   objc-class-instance-variables:
 ///     '{' objc-instance-variable-decl-list[opt] '}'
@@ -1260,7 +1276,6 @@ void Parser::ParseObjCClassInstanceVaria
 
   BalancedDelimiterTracker T(*this, tok::l_brace);
   T.consumeOpen();
-
   // While we still have something to read, read the instance variables.
   while (Tok.isNot(tok::r_brace) && Tok.isNot(tok::eof)) {
     // Each iteration of this loop reads one objc-instance-variable-decl.
@@ -1288,13 +1303,17 @@ void Parser::ParseObjCClassInstanceVaria
         visibility = Tok.getObjCKeywordID();
         ConsumeToken();
         continue;
-      case tok::objc_end:
-        Diag(Tok, diag::err_objc_unexpected_atend);
-        ConsumeToken();
-        continue;
       default:
-        Diag(Tok, diag::err_objc_illegal_visibility_spec);
-        continue;
+        Diag(Tok, (Tok.getObjCKeywordID() == tok::objc_end) ?
+             diag::err_objc_unexpected_atend :
+             diag::err_objc_illegal_visibility_spec);
+        Tok.setLocation(Tok.getLocation().getLocWithOffset(-1));
+        Tok.setKind(tok::at);
+        Tok.setLength(1);
+        PP.EnterToken(Tok);
+        HelperActionsForIvarDeclarations(interfaceDecl, atLoc,
+                                         T, AllIvarDecls, true);
+        return;
       }
     }
 
@@ -1341,16 +1360,8 @@ void Parser::ParseObjCClassInstanceVaria
       SkipUntil(tok::r_brace, true, true);
     }
   }
-  T.consumeClose();
-
-  Actions.ActOnObjCContainerStartDefinition(interfaceDecl);
-  Actions.ActOnLastBitfield(T.getCloseLocation(), AllIvarDecls);
-  Actions.ActOnObjCContainerFinishDefinition();
-  // Call ActOnFields() even if we don't have any decls. This is useful
-  // for code rewriting tools that need to be aware of the empty list.
-  Actions.ActOnFields(getCurScope(), atLoc, interfaceDecl,
-                      AllIvarDecls,
-                      T.getOpenLocation(), T.getCloseLocation(), 0);
+  HelperActionsForIvarDeclarations(interfaceDecl, atLoc,
+                                   T, AllIvarDecls, false);
   return;
 }
 

Modified: cfe/trunk/test/Parser/missing-closing-rbrace.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/missing-closing-rbrace.m?rev=177549&r1=177548&r2=177549&view=diff
==============================================================================
--- cfe/trunk/test/Parser/missing-closing-rbrace.m (original)
+++ cfe/trunk/test/Parser/missing-closing-rbrace.m Wed Mar 20 13:09:33 2013
@@ -1,6 +1,12 @@
 // RUN: %clang_cc1 -fsyntax-only -verify %s
 // rdar: //6854840
- at interface A {@end // expected-error {{'@end' appears where closing brace '}' is expected}}\
-                   // expected-note {{to match this '{'}}\
-                   // expected-note {{class started here}}
-		   // expected-error {{expected '}'}} expected-error {{missing '@end'}}
+ at interface A {@end // expected-error {{'@end' appears where closing brace '}' is expected}}
+
+
+ at interface B {
+ at public
+  int ivar;
+ at protected
+  id pp;
+ at property (copy) id PROP; // expected-error {{illegal visibility specification}}
+ at end