r177368 - Finish refactoring the tool selection logic.

[Benyei, Guy]

Hi,
I'm not really an expert of this issue, but it sounds right to fail with an error message, and then gracefully exit. The test could be XFAIL in windows.

Thanks
    Guy


-----Original Message-----
From: Rafael Espíndola [mailto:rafael.espindola at gmail.com] 
Sent: Tuesday, March 19, 2013 16:27
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: r177368 - Finish refactoring the tool selection logic.

On 19 March 2013 07:37, Benyei, Guy <guy.benyei at intel.com> wrote:
> Hi Rafael,
> Apparently this change breaks the Windows build: the test Driver\inhibit-downstream-commands.c runs into the unreachable you've added in the WindowsToolChain.cpp.
> I guess the test should be fixed, please check on this.

Should be fixed in r177398. Since you are using windows: which one would you find less surprising: clang printing an error message saying -no-integrated-as is not supported on windows or it silently using the integrated assembler? With r177398 we are back to using the integrated assembler, but I can implement a proper error if you want.

> Thanks
>     Guy

Thanks,
Rafael
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.