[Patch] Fix redundant comparison in gcc::Common::ConstructJob

Hans Wennborg hans at chromium.org
Tue Mar 19 10:57:35 PDT 2013


On Sun, Mar 17, 2013 at 10:37 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> On 17 March 2013 10:52, Hans Wennborg <hans at chromium.org> wrote:
>> I found the suspect expression "Arch == llvm::Triple::x86_64 || Arch
>> == llvm::Triple::x86_64" in gcc::Common::ConstructJob. It seems the
>> right-hand side used to check for powerpc64, but got lost in a
>> refactoring.
>>
>> The attached patch fixes this and tries to update the test too.
>
> The patch itself looks good, but if it is not too much to ask, could
> you also change test/Driver/unknown-gcc-arch.c to use FileCheck?

Attaching new patch with FileCheckized test.

OK to commit?

Thanks,
Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcc_construct_job_ppc64_fix2.patch
Type: application/octet-stream
Size: 2497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130319/ecc1be24/attachment.obj>


More information about the cfe-commits mailing list