r177300 - Inline ShouldUseIntegratedAssembler and move the documentation to

[Rafael Espindola]

Author: rafael
Date: Mon Mar 18 12:58:22 2013
New Revision: 177300

URL: http://llvm.org/viewvc/llvm-project?rev=177300&view=rev
Log:
Inline ShouldUseIntegratedAssembler and move the documentation to
useIntegratedAs.

Modified:
    cfe/trunk/include/clang/Driver/ToolChain.h
    cfe/trunk/lib/Driver/Tools.cpp

Modified: cfe/trunk/include/clang/Driver/ToolChain.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/ToolChain.h?rev=177300&r1=177299&r2=177300&view=diff
==============================================================================
--- cfe/trunk/include/clang/Driver/ToolChain.h (original)
+++ cfe/trunk/include/clang/Driver/ToolChain.h Mon Mar 18 12:58:22 2013
@@ -137,6 +137,7 @@ public:
   /// by default.
   virtual bool IsIntegratedAssemblerDefault() const { return false; }
 
+  /// \brief Check if the toolchain should use the integrated assembler.
   bool useIntegratedAs(const ArgList &Args) const;
 
   /// IsStrictAliasingDefault - Does this tool chain use -fstrict-aliasing by

Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=177300&r1=177299&r2=177300&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Mon Mar 18 12:58:22 2013
@@ -1414,20 +1414,13 @@ static void addExceptionArgs(const ArgLi
     CmdArgs.push_back("-fexceptions");
 }
 
-/// \brief Check if the toolchain should use the integrated assembler.
-static bool ShouldUseIntegratedAssembler(const ArgList &Args,
-                                         const ToolChain &TC) {
-  // FIXME: inline
-  return TC.useIntegratedAs(Args);
-}
-
 static bool ShouldDisableCFI(const ArgList &Args,
                              const ToolChain &TC) {
   bool Default = true;
   if (TC.getTriple().isOSDarwin()) {
     // The native darwin assembler doesn't support cfi directives, so
     // we disable them if we think the .s file will be passed to it.
-    Default = ShouldUseIntegratedAssembler(Args, TC);
+    Default = TC.useIntegratedAs(Args);
   }
   return !Args.hasFlag(options::OPT_fdwarf2_cfi_asm,
                        options::OPT_fno_dwarf2_cfi_asm,
@@ -1438,7 +1431,7 @@ static bool ShouldDisableDwarfDirectory(
                                         const ToolChain &TC) {
   bool UseDwarfDirectory = Args.hasFlag(options::OPT_fdwarf_directory_asm,
                                         options::OPT_fno_dwarf_directory_asm,
-                                        ShouldUseIntegratedAssembler(Args, TC));
+                                        TC.useIntegratedAs(Args));
   return !UseDwarfDirectory;
 }
 
@@ -2813,7 +2806,7 @@ void Clang::ConstructJob(Compilation &C,
   // -fmodules-autolink (on by default when modules is enabled) automatically
   // links against libraries for imported modules.  This requires the
   // integrated assembler.
-  if (HaveModules && ShouldUseIntegratedAssembler(Args, getToolChain()) &&
+  if (HaveModules && getToolChain().useIntegratedAs(Args) &&
       Args.hasFlag(options::OPT_fmodules_autolink,
                    options::OPT_fno_modules_autolink,
                    true)) {