r177218 - Remove -Wspellcheck and replace it with a diagnostic option.

Argyrios Kyrtzidis akyrtzi at gmail.com
Sat Mar 16 10:41:43 PDT 2013


On Mar 16, 2013, at 10:13 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Sat, Mar 16, 2013 at 3:40 AM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:
>> Author: akirtzidis
>> Date: Fri Mar 15 20:40:35 2013
>> New Revision: 177218
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=177218&view=rev
>> Log:
>> Remove -Wspellcheck and replace it with a diagnostic option.
>> 
>> Thanks to Richard S. for pointing out that the warning would show up
>> with -Weverything.
> 
> If we are going to start testing clang this way, it would be better to
> design this first, so that adding new 'testing' diagnostics is easy
> *and* does not slow down the normal compilation.  I think the second
> part is addressed already.
> 
> For example, adding a command line option every time is excessive.
> This option could be renamed to -fclang-debugging-diagnostics, and all
> such diagnostics could be placed under a special flag
> -Wclang-debugging.

Maybe we should have a few more similar cases before designing a general solution.
The only other similar case that I know of currently is "-error-on-deserialized-decl=" which is handled quite differently.

> 
> Dmitri
> 
> -- 
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/





More information about the cfe-commits mailing list