modularize patch - request for review

Thompson, John John_Thompson at playstation.sony.com
Fri Mar 8 18:21:06 PST 2013


Hi,

I've taken Doug's modularize tool, a very useful tool for checking a group of headers for being ready for the new modules feature, and added some fixes for building on Windows and Linux, and an enhancement to print the source file name for the "not always provided" messages.

I'd like to check this in to the clang-tool-extra repository.  I plan to do some more work here, but I thought it would be good to start tracking this tool.  Doug suggested I post here to give you a chance to look at it.

If you have interest in this, please do review the enclosed patch and post your feedback and a thumbs-up for checking it in.  The patch is relative to the tools/clang/tools/extra directory, where the clang-tool-extra tree is normally put.

The modularize tool takes as input a file name of a file with a list of header files to check, and outputs error messages for things it considers problematic for modules.  Note that it also accepts normal front end options as well.

Note that I wasn't sure if I should add something to the extra/doc directory, but I will if you indicate such.

Thanks.

-John


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130309/ae22b430/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modularize.patch
Type: application/octet-stream
Size: 15637 bytes
Desc: modularize.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130309/ae22b430/attachment.obj>


More information about the cfe-commits mailing list