r176428 - Perform non-overload placeholder conversions on the operands

[John McCall]

On Mar 8, 2013, at 5:13 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Fri, Mar 8, 2013 at 5:07 PM, John McCall <rjmccall at apple.com> wrote:
> Oh, I must have.
> 
>> Several more of your recent commits have converted variables from the InitialCaps style required by the coding standard to an initialLowercase form.
> 
> Oh, did that get formalized?  That's unfortunate for quite a few reasons.  Maybe LLVM is consistent about it, but Clang's code base is pretty far from that, particularly in IR-gen.
> 
> It did, and it is much more consistent in LLVM and other parts of Clang. Not really endorsing it, but I figure we should all suffer through it or get Chris to change it. ;]

How's that reformatting tool coming along? :)

I mean, there's also mass inconsistency in LLVM and Clang about capitalization of methods.  Or rather, there isn't:  I would estimate that LLVM and Clang are ~90% consistent with a convention of capitalizing the first letter in a method name, and (1) that also contradicts the style guide and (2) it actually *matters* because everybody using that method has to be aware of it.

It seems clear to me that we're going to have a red letter day sooner or later where we rename a bunch of LLVM APIs, and if we do that, we should also change the local variable convention to something that LLVM contributors don't essentially universally dislike.

John.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130308/ceaa3afd/attachment.html>