[PATCH] Extend loop variable naming checks

Jack Yang jack.yang at intel.com
Thu Mar 7 08:37:13 PST 2013


  Addressed all review comments. Thanks. Plus a few minor improvements.

  - Added a few comments in the naming-alias test. The test case was copied from the original naming test, but I've added a few comments to explain what loop convert is trying to do.
  - Readded the hardcoding of variable names to all loop convert tests.
  - Changed DeclFinderASTVisitor::VisitTypeLoc(). Turns out in the previous version, it wasn't handling for typedefs properly and was actually failing one of the typedef tests.
  - Added a namespace test .

Hi klimek,

http://llvm-reviews.chandlerc.com/D484

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D484?vs=1201&id=1207#toc

Files:
  cpp11-migrate/LoopConvert/LoopActions.cpp
  cpp11-migrate/LoopConvert/StmtAncestor.cpp
  cpp11-migrate/LoopConvert/StmtAncestor.h
  cpp11-migrate/LoopConvert/VariableNaming.cpp
  cpp11-migrate/LoopConvert/VariableNaming.h
  test/cpp11-migrate/Combined/combined.cpp
  test/cpp11-migrate/LoopConvert/array.cpp
  test/cpp11-migrate/LoopConvert/confidence.cpp
  test/cpp11-migrate/LoopConvert/dependency.cpp
  test/cpp11-migrate/LoopConvert/iterator.cpp
  test/cpp11-migrate/LoopConvert/naming-alias.cpp
  test/cpp11-migrate/LoopConvert/naming-conflict.cpp
  test/cpp11-migrate/LoopConvert/naming.cpp
  test/cpp11-migrate/LoopConvert/nesting.cpp
  test/cpp11-migrate/LoopConvert/pseudoarray.cpp
  test/cpp11-migrate/LoopConvert/single-iterator.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D484.3.patch
Type: text/x-patch
Size: 34086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130307/219f30d0/attachment.bin>


More information about the cfe-commits mailing list