[PATCH] Adding lvalue and rvalue reference type matchers

[Manuel Klimek]

  LG. I'm not sure whether lvalueReference or lValueReference is what people would expect, so I leave that part open for discussion ;)


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2953
@@ +2952,3 @@
+/// \c lvalueReferenceType() matches the type of \c b.
+AST_TYPE_MATCHER(LValueReferenceType, lvalueReferenceType);
+
----------------
Seems like the correct indentation would be lValueReferenceType? (I can see why we might not want that ;)

================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2942
@@ +2941,3 @@
+///
+/// See C++ [dcl.ref].
+///
----------------
I'd vote against putting in comments that reference the C++ standard. Instead, we should put those comments on the AST nodes themselves. If I remember correctly, there was a lot of agreement on the idea of better doxygen comments for the AST nodes, but so far nobody has stepped up :)


http://llvm-reviews.chandlerc.com/D503

BRANCH
  rlvalue_ref

ARCANIST PROJECT
  clang