[RFC] #pragma ivdep

Pekka Jääskeläinen pekka.jaaskelainen at tut.fi
Wed Mar 6 12:42:37 PST 2013


Hi Paul,

On 03/06/2013 10:11 PM, Redmond, Paul wrote:
> I have updated the patch to not add metadata on loads and stores where the
> pointer comes from an alloca. I wonder if the check should be more
> conservative and only include pointers coming from Arguments and GlobalValues
> (perhaps Constants too?)

I think it's safer that way around for now.

+/// Assuming I is in a parallel loop, return true if I needs
+/// llvm.mem.parallel_loop_access metadata.
+static bool AnnotateParallelLoopAccess(llvm::Instruction *I) {

So maybe this comment should be
"...return true if llvm.mem.parallel_loop_access metadata
can be added safely to I."

-- 
--Pekka




More information about the cfe-commits mailing list