[PATCH] Extend loop variable naming checks

Jack Yang jack.yang at intel.com
Wed Mar 6 12:22:20 PST 2013


  As per suggestions, the fix for this issue has been completely reimplemented. The original variable naming logic will still exist, but the checks for conflicts has been extended to check for language keywords (including aliases), macros, and types.

  New tests have been added. Also renamed naming.cpp to naming-alias.cpp but I guess git diff treats it as a new file instead of a rename.

Hi klimek,

http://llvm-reviews.chandlerc.com/D484

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D484?vs=1165&id=1201#toc

Files:
  cpp11-migrate/LoopConvert/LoopActions.cpp
  cpp11-migrate/LoopConvert/StmtAncestor.cpp
  cpp11-migrate/LoopConvert/StmtAncestor.h
  cpp11-migrate/LoopConvert/VariableNaming.cpp
  cpp11-migrate/LoopConvert/VariableNaming.h
  test/cpp11-migrate/LoopConvert/naming-alias.cpp
  test/cpp11-migrate/LoopConvert/naming-conflict.cpp
  test/cpp11-migrate/LoopConvert/naming.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D484.2.patch
Type: text/x-patch
Size: 11575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130306/a8d65b5a/attachment.bin>


More information about the cfe-commits mailing list