[PATCH] Minor refactor of how we get compilation phases.

[Daniel Dunbar]

On Wed, Mar 6, 2013 at 10:06 AM, Matthew Curtis <mcurtis at codeaurora.org>wrote:

>  On 3/6/2013 11:12 AM, Daniel Dunbar wrote:
>
> Hi Matthew,
>
>  Is the motivation just as a cleanup?
>
> Primarily cleanup, though we have an internal project that involves adding
> a new phase. This makes it a little more straightforward to do so.
>

Ah, cool.


>
>
>  Specific comments on the patch:
>
>  1. getCompilationPhases should take the phase list as a reference not a
> pointer, this is more consistent.
>
>  2. Don't .clear() the list in getCompilationPhases.
>
>  3. There aren't enough uses to be worth introducing the PhaseList type,
> just write out the SmallVector which makes the code more verbose but more
> familiar.
>
>   New patch attached incorporating this feedback.
>

LGTM.

 - Daniel


> Thanks for the review!
> Matthew Curtis
>
>
>   - Daniel
>
>
>
> On Wed, Mar 6, 2013 at 6:04 AM, Matthew Curtis <mcurtis at codeaurora.org>wrote:
>
>>  Hello Daniel,
>>
>> Do you have time to comment on this patch?
>>
>> Thanks,
>> Matthew Curtis.
>>
>>
>> On 3/1/2013 4:17 PM, Matthew Curtis wrote:
>>
>> There is now a single function to get the list of phases for a given
>> output Type.
>>
>> No functionality change intended.
>>
>> Thanks,
>> Matthew Curtis
>>
>>
>>
>>  _______________________________________________
>> cfe-commits mailing listcfe-commits at cs.uiuc.eduhttp://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>>
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>>
>>
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130306/ac0d8615/attachment.html>