[cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM

[Rafael Espíndola]

LGTM.

On 5 March 2013 14:55, Weiming Zhao <weimingz at codeaurora.org> wrote:
> Hi Rafael,
>
> Thanks for reviewing.
> The line is needed because Opts.Triple is a string, not a Triple object.
>
> Attached is the rebased patch (no new changes).
>
> Thanks,
> Weiming
>
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>
>
> -----Original Message-----
> From: Rafael Espíndola [mailto:rafael.espindola at gmail.com]
> Sent: Monday, March 04, 2013 1:29 PM
> To: weimingz at codeaurora.org
> Cc: cfe-commits at cs.uiuc.edu; Anton Korobeynikov
> Subject: Re: [cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM
>
> On 4 March 2013 16:20, Weiming Zhao <weimingz at codeaurora.org> wrote:
>> Ping?
>
> +  llvm::Triple T(Opts.Triple);
>
> Can you avoid the copy with something like
>
> const llvm::Triple &T = Opts.Triple?
>
> OK with that change.
>
> Cheers,
> Rafael