[PATCH] multiple inlining scopes for a single source location

Adrian Prantl aprantl at apple.com
Fri Mar 1 17:53:56 PST 2013


On Wed Feb 27 12:45:37 Manman Ren wrote:
> Given an example with two function calls in a single line, without -gcolumn-info, both function calls will be at the same source location.
> And Clang will generate a single coalesced inlining scope since we unique scopes by the source location.
> 
> Even without -gcolumn-info, we should generate two inlining scopes. This means we should differentiate the different call sites with the same source location.
> One option is to use the column info in SourceLoc to store the call site id when -gcolumn-info is not on.
> 
> Any problem with this? Any other better suggestions?

Here’s a patch for review that implements this. I’m using the actual column info rather than the (arbitrary?) call site id.

thanks,
Adrian

---------

Force column info to be generated for call expressions so we
can differentiate multiple call sites on the same line in the
debug info.

Fixes rdar://problem/13036237

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Force-column-info-to-be-generated-for-call-expressio.patch
Type: application/octet-stream
Size: 6080 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130301/ec9219cb/attachment.obj>


More information about the cfe-commits mailing list